I would say that the answer to whether the spell works relies more upon what exactly your expectations are. What, precisely, do you expect to achieve with this working?
In my opinion the spell is incomplete. The beginning of it is OK, but what do you do with the rings after you have used them in the spell? Do you wear them? Do you bury them in the Earth? Do you keep them in a special place in your house? The spell doesn't say. It seems to me that what wraps up the spell and keeps it working is what is done once you have cast the spell. Personally, I would want to wear the rings once they are charged to keep the energies near me.
Also, remember that a spell is more than just saying the words in the spell. It is all about focus on the goal of the spell, the intention of the spell, and on your ability to gather and direct energy towards the goal of the spell.
Quest, when I asked what exactly your expectations are, I did ask precisely what your expectations are with this spell.
Saying your dreams will come true means nothing to people who don't know your dreams. So I will ask a second and final time: What exactly, precisely, and specifically, are you wanting to do with this spell?
I agree that this spell seems incomplete or lacking the instructions for where the rings are kept or what happens to them after the verbalaspect are complete. Are the ringsto remain charging on an alter for a specific length of time? Are they to charge alongside the representations of the elements or by themselves? Do the ringsneed to charge under the moon, such as during the waxing phase? For you are trying to increase the rings connections to the elements as well as to you so that you absorb all the aspects desired. Do you wear any of these rings, carry them with you in a pouch or secure in a box for safe keeping or display them in any such way as you manifest your desire? This seems like a good start to a spell that may help manifest your dreams but you will need to complete the spell. I for one may add an anointing oil to the rings as I state the intention for each specific ring tp help increase the energy or vibration of the casting. One can also light a candle specific to certain aspects of the spell such as lighting a candle in scribed with Theban script to attract nature spirits like the ones mentioned in the spell we are discussing.
Below are links to some of the items mentioned above as well as others you may find helpful;